hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharat Viswanadham (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-16248) Fix MutableQuantiles memory leak
Date Thu, 16 May 2019 01:06:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-16248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840893#comment-16840893

Bharat Viswanadham edited comment on HADOOP-16248 at 5/16/19 1:06 AM:

Hi [~adaboville]

You can create a patch with below format.

<<JiraNo>>.<<PatchVersion>>.patch. In your case, it will be HADOOP-16248.00.pathc

was (Author: bharatviswa):
Hi [~adaboville]

You can create a patch with below format.


> Fix MutableQuantiles memory leak
> --------------------------------
>                 Key: HADOOP-16248
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16248
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.9.2
>            Reporter: Alexis Daboville
>            Priority: Major
>         Attachments: mutable-quantiles-leak.png, mutable-quantiles.patch
> In some circumstances (high GC, high CPU usage, creating lots of
>  S3AFileSystem) it is possible for MutableQuantiles::scheduler [1] to fall
>  behind processing tasks that are submitted to it; because tasks are
>  submitted on a regular schedule, the unbounded queue backing the
>  {{ExecutorService}} might grow to several gigs [2]. By using
>  {{scheduleWithFixedDelay}} instead, we ensure that under pressure this leak won't
>  happen. In order to mitigate the growth, a simple fix [3] is proposed, simply replacing
{{scheduler.scheduleAtFixedRate}} by {{scheduler.scheduleWithFixedDelay}}.
> [1] it is single threaded and shared across all instances of {{MutableQuantiles}}: [https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableQuantiles.java#L66-L68]
> [2] see attached mutable-quantiles-leak.png.
> [3] mutable-quantiles.patch

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message