hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] hadoop-yetus commented on issue #1308: HDDS-1974. Implement OM CancelDelegationToken request to use Cache and DoubleBuffer.
Date Sat, 17 Aug 2019 03:07:31 GMT
hadoop-yetus commented on issue #1308: HDDS-1974. Implement OM CancelDelegationToken request
to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/1308#issuecomment-522199198
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | 0 | reexec | 39 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -1 | test4tests | 0 | The patch doesn't appear to include any new or modified tests.
 Please justify why no new tests are needed for this patch. Also please list what manual steps
were performed to verify this patch. |
   ||| _ trunk Compile Tests _ |
   | 0 | mvndep | 27 | Maven dependency ordering for branch |
   | +1 | mvninstall | 583 | trunk passed |
   | +1 | compile | 342 | trunk passed |
   | +1 | checkstyle | 61 | trunk passed |
   | +1 | mvnsite | 0 | trunk passed |
   | +1 | shadedclient | 808 | branch has no errors when building and testing our client artifacts.
|
   | +1 | javadoc | 168 | trunk passed |
   | 0 | spotbugs | 457 | Used deprecated FindBugs config; considering switching to SpotBugs.
|
   | +1 | findbugs | 674 | trunk passed |
   | -0 | patch | 490 | Used diff version of patch file. Binary files and potentially other
changes not applied. Please rebase and squash commits if necessary. |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 16 | Maven dependency ordering for patch |
   | +1 | mvninstall | 615 | the patch passed |
   | +1 | compile | 382 | the patch passed |
   | +1 | javac | 382 | the patch passed |
   | -0 | checkstyle | 38 | hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed
= 1 total (was 0) |
   | +1 | mvnsite | 0 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedclient | 667 | patch has no errors when building and testing our client artifacts.
|
   | +1 | javadoc | 165 | the patch passed |
   | -1 | findbugs | 471 | hadoop-ozone generated 2 new + 0 unchanged - 0 fixed = 2 total
(was 0) |
   ||| _ Other Tests _ |
   | +1 | unit | 293 | hadoop-hdds in the patch passed. |
   | -1 | unit | 2149 | hadoop-ozone in the patch failed. |
   | +1 | asflicense | 40 | The patch does not generate ASF License warnings. |
   | | | 7954 | |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:hadoop-ozone |
   |  |  Null passed for non-null parameter of new org.apache.hadoop.ozone.om.response.security.OMCancelDelegationTokenResponse(OzoneTokenIdentifier,
OzoneManagerProtocolProtos$OMResponse) in org.apache.hadoop.ozone.om.request.security.OMCancelDelegationTokenRequest.validateAndUpdateCache(OzoneManager,
long, OzoneManagerDoubleBufferHelper)  At OMCancelDelegationTokenRequest.java:of new org.apache.hadoop.ozone.om.response.security.OMCancelDelegationTokenResponse(OzoneTokenIdentifier,
OzoneManagerProtocolProtos$OMResponse) in org.apache.hadoop.ozone.om.request.security.OMCancelDelegationTokenRequest.validateAndUpdateCache(OzoneManager,
long, OzoneManagerDoubleBufferHelper)  At OMCancelDelegationTokenRequest.java:[line 101] |
   |  |  Null passed for non-null parameter of new org.apache.hadoop.ozone.om.response.security.OMGetDelegationTokenResponse(OzoneTokenIdentifier,
long, OzoneManagerProtocolProtos$OMResponse) in org.apache.hadoop.ozone.om.request.security.OMGetDelegationTokenRequest.validateAndUpdateCache(OzoneManager,
long, OzoneManagerDoubleBufferHelper)  At OMGetDelegationTokenRequest.java:of new org.apache.hadoop.ozone.om.response.security.OMGetDelegationTokenResponse(OzoneTokenIdentifier,
long, OzoneManagerProtocolProtos$OMResponse) in org.apache.hadoop.ozone.om.request.security.OMGetDelegationTokenRequest.validateAndUpdateCache(OzoneManager,
long, OzoneManagerDoubleBufferHelper)  At OMGetDelegationTokenRequest.java:[line 140] |
   | Failed junit tests | hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient |
   |   | hadoop.ozone.TestStorageContainerManager |
   |   | hadoop.ozone.TestMiniChaosOzoneCluster |
   |   | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption |
   |   | hadoop.ozone.client.rpc.TestFailureHandlingByClient |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1308/4/artifact/out/Dockerfile
|
   | GITHUB PR | https://github.com/apache/hadoop/pull/1308 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient
findbugs checkstyle |
   | uname | Linux 0e80f25b8f49 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018
x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 8d754c2 |
   | Default Java | 1.8.0_222 |
   | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1308/4/artifact/out/diff-checkstyle-hadoop-ozone.txt
|
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1308/4/artifact/out/new-findbugs-hadoop-ozone.html
|
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1308/4/artifact/out/patch-unit-hadoop-ozone.txt
|
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1308/4/testReport/
|
   | Max. process+thread count | 4079 (vs. ulimit of 5500) |
   | modules | C: hadoop-ozone/common hadoop-ozone/ozone-manager U: hadoop-ozone |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1308/4/console
|
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message