hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1315: HDDS-1975. Implement default acls for bucket/volume/key for OM HA code.
Date Fri, 23 Aug 2019 19:23:52 GMT
xiaoyuyao commented on a change in pull request #1315: HDDS-1975. Implement default acls for
bucket/volume/key for OM HA code.
URL: https://github.com/apache/hadoop/pull/1315#discussion_r317271309
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java
 ##########
 @@ -447,4 +497,31 @@ private OMClientResponse createKeyErrorResponse(@Nonnull OMMetrics omMetrics,
     }
   }
 
+  /**
+   * Check Acls for the ozone object.
+   * @param ozoneManager
+   * @param volume
+   * @param bucket
+   * @param key
+   * @param checkKeyAccess
+   * @throws IOException
+   */
+  protected void checkKeyAcls(OzoneManager ozoneManager, String volume,
 
 Review comment:
   Suggest to refactor into two separate APIs one for checkKeyAccess and one for checkBucketAccess
to avoid confusion. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message