hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15998) Jar validation bash scripts don't work on Windows due to platform differences (colons in paths, \r\n)
Date Fri, 23 Aug 2019 22:06:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914675#comment-16914675
] 

Sean Busbey commented on HADOOP-15998:
--------------------------------------

v5

- get all the artifacts passed instead of the first
- error if no artifacts
- fail if any command fails
- change reading of jar contents to avoid shell handling
- added a bash 3.1 check that we should have had before

tested locally on mac. verified that all jars are being tested, that things fail on {{jar}}
command failure, that things fail when something isn't relocated, and that things pass correctly.

> Jar validation bash scripts don't work on Windows due to platform differences (colons
in paths, \r\n)
> -----------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-15998
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15998
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.2.0, 3.3.0
>         Environment: Windows 10
> Visual Studio 2017
>            Reporter: Brian Grunkemeyer
>            Assignee: Brian Grunkemeyer
>            Priority: Blocker
>              Labels: build, windows
>         Attachments: HADOOP-15998.5.patch, HADOOP-15998.v4.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Building Hadoop fails on Windows due to a few shell scripts that make invalid assumptions:
> 1) Colon shouldn't be used to separate multiple paths in command line parameters. Colons
occur in Windows paths.
> 2) Shell scripts that rely on running external tools need to deal with carriage return
- line feed differences (lines ending in \r\n, not just \n)



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message