hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Krogen (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-16268) Allow custom wrapped exception to be thrown by server if RPC call queue is filled up
Date Fri, 23 Aug 2019 15:34:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-16268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914353#comment-16914353
] 

Erik Krogen commented on HADOOP-16268:
--------------------------------------

+1 on the latest patch

> Allow custom wrapped exception to be thrown by server if RPC call queue is filled up
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-16268
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16268
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: CR Hota
>            Assignee: CR Hota
>            Priority: Major
>         Attachments: HADOOP-16268.001.patch, HADOOP-16268.002.patch, HADOOP-16268.003.patch,
HADOOP-16268.004.patch
>
>
> In the current implementation of callqueue manager, "CallQueueOverflowException" exceptions
are always wrapping "RetriableException". Through configs servers should be allowed to throw
custom exceptions based on new use cases.
> In CallQueueManager.java for backoff the below is done 
> {code:java}
>   // ideally this behavior should be controllable too.
>   private void throwBackoff() throws IllegalStateException {
>     throw CallQueueOverflowException.DISCONNECT;
>   }
> {code}
> Since CallQueueOverflowException only wraps RetriableException clients would end up hitting
the same server for retries. In use cases that router supports these overflowed requests could
be handled by another router that shares the same state thus distributing load across a cluster
of routers better. In the absence of any custom exception, current behavior should be supported.
> In CallQueueOverflowException class a new Standby exception wrap should be created. Something
like the below
> {code:java}
>    static final CallQueueOverflowException KEEPALIVE =
>         new CallQueueOverflowException(
>             new RetriableException(TOO_BUSY),
>             RpcStatusProto.ERROR);
>     static final CallQueueOverflowException DISCONNECT =
>         new CallQueueOverflowException(
>             new RetriableException(TOO_BUSY + " - disconnecting"),
>             RpcStatusProto.FATAL);
>     static final CallQueueOverflowException DISCONNECT2 =
>         new CallQueueOverflowException(
>             new StandbyException(TOO_BUSY + " - disconnecting"),
>             RpcStatusProto.FATAL);
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message