hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei-Chiu Chuang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-16351) Change ":" to ApplicationConstants.CLASS_PATH_SEPARATOR
Date Sat, 17 Aug 2019 00:25:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-16351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16909507#comment-16909507
] 

Wei-Chiu Chuang commented on HADOOP-16351:
------------------------------------------

Ok Thanks! +1 from me. Committing this now.
I didn't know dollar sign is a valid character for method names. Learned a new thing today.

> Change ":" to ApplicationConstants.CLASS_PATH_SEPARATOR
> -------------------------------------------------------
>
>                 Key: HADOOP-16351
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16351
>             Project: Hadoop Common
>          Issue Type: Task
>          Components: common
>    Affects Versions: 3.1.2
>            Reporter: kevin su
>            Assignee: kevin su
>            Priority: Trivial
>             Fix For: 3.1.2
>
>         Attachments: HADOOP-16351.01.patch
>
>
> under distributedshell/Clients.java 
> We should change ":" to ApplicationConstants.CLASS_PATH_SEPARATOR, so it could also support
Windows client
> {code}
> // add the runtime classpath needed for tests to work
>     if (conf.getBoolean(YarnConfiguration.IS_MINI_YARN_CLUSTER, false)) {
>       classPathEnv.append(':')
>           .append(System.getProperty("java.class.path"));
>     }
> {code}
> {code}
> // add the runtime classpath needed for tests to work
>     if (conf.getBoolean(YarnConfiguration.IS_MINI_YARN_CLUSTER, false)) {
>       classPathEnv.append(ApplicationConstants.CLASS_PATH_SEPARATOR)
>           .append(System.getProperty("java.class.path"));
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message