hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-16488) Remove JsonSerialization from hadoop-common
Date Tue, 06 Aug 2019 09:03:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-16488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16900797#comment-16900797
] 

Steve Loughran commented on HADOOP-16488:
-----------------------------------------

oder is

java.*
--
javax
--
non-org.apache
--
org.apache
--
statics

No .* except optionally for statics.

it's not strictly enforced the way, say Spark does (with automated review), but it's generally
preferred, and a key thing: leave existing imports unchanged (generally), new stuff tries
to restore order.

spurious import conflict is one of the key troublespots in backporting; two independent PRs
touching adjacent lines of code. That's why minimal diffs here are good

> Remove JsonSerialization from hadoop-common
> -------------------------------------------
>
>                 Key: HADOOP-16488
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16488
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: common
>            Reporter: Duo Zhang
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message