hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-11866) increase readability and reliability of checkstyle, shellcheck, and whitespace reports
Date Tue, 10 Sep 2019 00:11:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521847#comment-14521847
] 

Allen Wittenauer edited comment on HADOOP-11866 at 9/10/19 12:10 AM:
---------------------------------------------------------------------

\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec |   0m  0s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch |   0m  0s | Pre-patch trunk compilation is healthy. |
| {color:blue}0{color} | @author |   0m  0s | Skipping @author checks as test-patch has been
patched. |
| {color:green}+1{color} | release audit |   0m 16s | The applied patch does not increase
the total number of release audit warnings. |
| {color:blue}0{color} | shellcheck |   0m 16s | Shellcheck was not available. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| | |   0m 35s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12729531/HADOOP-11866-07.patch
|
| Optional Tests | shellcheck |
| git revision | trunk / de9404f |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6228/console |


This message was automatically generated.


was (Author: hadoopqa):
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec |   0m  0s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch |   0m  0s | Pre-patch trunk compilation is healthy. |
| {color:blue}0{color} | @author |   0m  0s | Skipping @author checks as test-patch has been
patched. |
| {color:green}+1{color} | release audit |   0m 16s | The applied patch does not increase
the total number of release audit warnings. |
| {color:blue}0{color} | shellcheck |   0m 16s | Shellcheck was not available. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| | |   0m 19s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12729531/HADOOP-11866-07.patch
|
| Optional Tests | shellcheck |
| git revision | trunk / de9404f |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6228/console |


This message was automatically generated.

> increase readability and reliability of checkstyle, shellcheck, and whitespace reports
> --------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11866
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11866
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Naganarasimha G R
>            Assignee: Allen Wittenauer
>            Priority: Minor
>             Fix For: 2.8.0, 3.0.0-alpha1
>
>         Attachments: HADOOP-11866-05.patch, HADOOP-11866-06.patch, HADOOP-11866-07.patch,
HADOOP-11866-08.patch, HADOOP-11866-checkstyle.patch, HADOOP-11866.20150422-1.patch, HADOOP-11866.20150423-1.patch,
HADOOP-11866.20150427-1.patch
>
>
> HADOOP-11746 supports listing of the lines which has trailing white spaces but doesn't
inform patch line number. Without this report output will not be of much help as in most cases
it reports blank lines. Also for the first timers it would be difficult to understand the
output check style script hence adding an header



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message