hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] steveloughran commented on a change in pull request #1516: HADOOP-16599. Allow a SignerInitializer to be specified along with a
Date Tue, 01 Oct 2019 12:22:49 GMT
steveloughran commented on a change in pull request #1516: HADOOP-16599. Allow a SignerInitializer
to be specified along with a
URL: https://github.com/apache/hadoop/pull/1516#discussion_r330025703
 
 

 ##########
 File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DelegationTokenProvider.java
 ##########
 @@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.s3a;
 
 Review comment:
   I worry it'd force even more version brittleness: "you are trying to use the hadoop-aws-plugins-3.2.1
with hadoop-aws-3.2.2". If you ever search for spark + s3 on stack overflow you can see that
the #1 recurrent complaint is ["I added hadoop-aws-3.1 to hadoop and now I get a class not
found exception](https://stackoverflow.com/questions/52310416/noclassdeffounderror-org-apache-hadoop-fs-streamcapabilities-while-reading-s3-d/).
   
   This is why the S3A troubleshooting docs start by telling people not to mix jars as all
they do is move stack traces around https://hadoop.apache.org/docs/current3/hadoop-aws/tools/hadoop-aws/troubleshooting_s3a.html#Classpath_Setup
   
   I don't want to make things worse. if you don't want the aws sdk, don't include it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message