hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] sodonnel commented on issue #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host
Date Tue, 01 Oct 2019 15:37:25 GMT
sodonnel commented on issue #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple
DNs on the same host
URL: https://github.com/apache/hadoop/pull/1551#issuecomment-537095584
 
 
   Findbug is warning about this method:
   
   ```  
   private synchronized void addEntryTodnsToUuidMap(
         String dnsName, String uuid) {
       Set<String> dnList = dnsToUuidMap.get(dnsName);
       if (dnList == null) {
         dnList = new HashSet<>();
         dnsToUuidMap.put(dnsName, dnList);
       }
       dnList.add(uuid);
     }
   ```
   As this is the only place dnsToUuidMap gets modified and it is synchronized, I think it
is OK.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message