hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] arp7 commented on a change in pull request #1521: HDDS-2073. Make SCMSecurityProtocol message based
Date Tue, 01 Oct 2019 18:26:39 GMT
arp7 commented on a change in pull request #1521: HDDS-2073. Make SCMSecurityProtocol message
based
URL: https://github.com/apache/hadoop/pull/1521#discussion_r330206688
 
 

 ##########
 File path: hadoop-hdds/common/src/main/proto/SCMSecurityProtocol.proto
 ##########
 @@ -30,33 +30,73 @@ option java_generic_services = true;
 
 option java_generate_equals_and_hash = true;
 
-package hadoop.hdds;
+package hadoop.hdds.security;
 
 import "hdds.proto";
 
+
+message SCMSecurityRequest {
 
 Review comment:
   A short comment here would be helpful for maintainers.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message