hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] hanishakoneru commented on a change in pull request #1486: HDDS-2158. Fixing Json Injection Issue in JsonUtils.
Date Tue, 01 Oct 2019 22:10:08 GMT
hanishakoneru commented on a change in pull request #1486: HDDS-2158. Fixing Json Injection
Issue in JsonUtils.
URL: https://github.com/apache/hadoop/pull/1486#discussion_r330298790
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/keys/GetAclKeyHandler.java
 ##########
 @@ -78,8 +78,8 @@ public Void call() throws Exception {
 
     List<OzoneAcl> result = client.getObjectStore().getAcl(obj);
 
-    System.out.printf("%s%n", JsonUtils.toJsonStringWithDefaultPrettyPrinter(
-        JsonUtils.toJsonString(result)));
+    System.out.printf("%s%n",
+        JsonUtils.toJsonStringWithDefaultPrettyPrinter(result));
 
 Review comment:
   Yes, _toJsonStringWithDefaultPrettyPrinter_ converts to string but in Json format (with
proper indentations and new line for each element). 
   Previously, we were converting the object to be printed to string (using _JsonUtils.toJsonString(result)_),
then converting it back into object (inside old _toJsonStringWithDefaultPrettyPrinter()_)
and then again converting it into string.
   ```
   //Old code
   public static String toJsonStringWithDefaultPrettyPrinter(String jsonString)
         throws IOException {
       Object json = READER.readValue(jsonString);
       return WRITTER.writeValueAsString(json);
     }
   ```
   The Json Injection issue happens when converting the jsonString back to Object without
validation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message