hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] hanishakoneru commented on a change in pull request #1486: HDDS-2158. Fixing Json Injection Issue in JsonUtils.
Date Tue, 01 Oct 2019 22:27:26 GMT
hanishakoneru commented on a change in pull request #1486: HDDS-2158. Fixing Json Injection
Issue in JsonUtils.
URL: https://github.com/apache/hadoop/pull/1486#discussion_r330304233
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/bucket/RemoveAclBucketHandler.java
 ##########
 @@ -92,8 +92,9 @@ public Void call() throws Exception {
     boolean result = client.getObjectStore().removeAcl(obj,
         OzoneAcl.parseAcl(acl));
 
-    System.out.printf("%s%n", JsonUtils.toJsonStringWithDefaultPrettyPrinter(
-        JsonUtils.toJsonString("Acl removed successfully: " + result)));
+    System.out.printf("%s%n", result ? "ACL removed successfully" :
+        "ACL not removed");
 
 Review comment:
   I reverted to previous print messages (fixing add/set/remove part only). 
   But I think that statement also does not convey the message properly. If we are trying
to add an already existing ACL, shouldn't we return true? And same for remove also. 
   We can open a new Jira to work on that if you agree.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message