hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] swagle commented on a change in pull request #1610: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete.
Date Wed, 09 Oct 2019 21:03:05 GMT
swagle commented on a change in pull request #1610: HDDS-1868. Ozone pipelines should be marked
as ready only after the leader election is complete.
URL: https://github.com/apache/hadoop/pull/1610#discussion_r333232187
 
 

 ##########
 File path: hadoop-hdds/container-service/src/main/proto/StorageContainerDatanodeProtocol.proto
 ##########
 @@ -239,6 +239,7 @@ message ContainerAction {
 
 message PipelineReport {
   required PipelineID pipelineID = 1;
+  optional bytes leaderID = 2;
 
 Review comment:
   Agree, but problem is on hdds side is google protobuf type and Ratis shades, so, if we
make it ByteString in pipeline then on client side we will have to do RaftPeerId.valueOf(...),
and make google ByteString to shaed one. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message