hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] hadoop-yetus commented on issue #1633: HDDS-2266. Avoid evaluation of LOG.trace and LOG.debug statement in the read/write path.
Date Thu, 10 Oct 2019 06:24:45 GMT
hadoop-yetus commented on issue #1633: HDDS-2266. Avoid evaluation of LOG.trace and LOG.debug
statement in the read/write path.
URL: https://github.com/apache/hadoop/pull/1633#issuecomment-540400768
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | 0 | reexec | 82 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -1 | test4tests | 0 | The patch doesn't appear to include any new or modified tests.
 Please justify why no new tests are needed for this patch. Also please list what manual steps
were performed to verify this patch. |
   ||| _ trunk Compile Tests _ |
   | 0 | mvndep | 70 | Maven dependency ordering for branch |
   | -1 | mvninstall | 43 | hadoop-hdds in trunk failed. |
   | -1 | mvninstall | 39 | hadoop-ozone in trunk failed. |
   | -1 | compile | 18 | hadoop-hdds in trunk failed. |
   | -1 | compile | 13 | hadoop-ozone in trunk failed. |
   | +1 | checkstyle | 61 | trunk passed |
   | +1 | mvnsite | 0 | trunk passed |
   | +1 | shadedclient | 943 | branch has no errors when building and testing our client artifacts.
|
   | -1 | javadoc | 19 | hadoop-hdds in trunk failed. |
   | -1 | javadoc | 16 | hadoop-ozone in trunk failed. |
   | 0 | spotbugs | 1030 | Used deprecated FindBugs config; considering switching to SpotBugs.
|
   | -1 | findbugs | 31 | hadoop-hdds in trunk failed. |
   | -1 | findbugs | 16 | hadoop-ozone in trunk failed. |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 24 | Maven dependency ordering for patch |
   | -1 | mvninstall | 31 | hadoop-hdds in the patch failed. |
   | -1 | mvninstall | 34 | hadoop-ozone in the patch failed. |
   | -1 | compile | 21 | hadoop-hdds in the patch failed. |
   | -1 | compile | 15 | hadoop-ozone in the patch failed. |
   | -1 | javac | 21 | hadoop-hdds in the patch failed. |
   | -1 | javac | 16 | hadoop-ozone in the patch failed. |
   | +1 | checkstyle | 52 | the patch passed |
   | +1 | mvnsite | 0 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedclient | 798 | patch has no errors when building and testing our client artifacts.
|
   | -1 | javadoc | 18 | hadoop-hdds in the patch failed. |
   | -1 | javadoc | 16 | hadoop-ozone in the patch failed. |
   | -1 | findbugs | 28 | hadoop-hdds in the patch failed. |
   | -1 | findbugs | 17 | hadoop-ozone in the patch failed. |
   ||| _ Other Tests _ |
   | -1 | unit | 24 | hadoop-hdds in the patch failed. |
   | -1 | unit | 22 | hadoop-ozone in the patch failed. |
   | +1 | asflicense | 29 | The patch does not generate ASF License warnings. |
   | | | 2596 | |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/Dockerfile
|
   | GITHUB PR | https://github.com/apache/hadoop/pull/1633 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient
findbugs checkstyle |
   | uname | Linux e4305c50b9de 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019
x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / eeb58a0 |
   | Default Java | 1.8.0_222 |
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/branch-mvninstall-hadoop-hdds.txt
|
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/branch-mvninstall-hadoop-ozone.txt
|
   | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/branch-compile-hadoop-hdds.txt
|
   | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/branch-compile-hadoop-ozone.txt
|
   | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/branch-javadoc-hadoop-hdds.txt
|
   | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/branch-javadoc-hadoop-ozone.txt
|
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/branch-findbugs-hadoop-hdds.txt
|
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/branch-findbugs-hadoop-ozone.txt
|
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/patch-mvninstall-hadoop-hdds.txt
|
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/patch-mvninstall-hadoop-ozone.txt
|
   | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/patch-compile-hadoop-hdds.txt
|
   | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/patch-compile-hadoop-ozone.txt
|
   | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/patch-compile-hadoop-hdds.txt
|
   | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/patch-compile-hadoop-ozone.txt
|
   | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/patch-javadoc-hadoop-hdds.txt
|
   | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/patch-javadoc-hadoop-ozone.txt
|
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/patch-findbugs-hadoop-hdds.txt
|
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/patch-findbugs-hadoop-ozone.txt
|
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/patch-unit-hadoop-hdds.txt
|
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/artifact/out/patch-unit-hadoop-ozone.txt
|
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/testReport/
|
   | Max. process+thread count | 341 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdds/common hadoop-ozone/client hadoop-ozone/common hadoop-ozone/ozone-manager
hadoop-ozone/ozonefs hadoop-ozone/s3gateway U: . |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1633/2/console
|
   | versions | git=2.7.4 maven=3.3.9 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message