hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] steveloughran commented on a change in pull request #1614: HADOOP-16615. Add password check for credential provider
Date Thu, 10 Oct 2019 17:27:31 GMT
steveloughran commented on a change in pull request #1614: HADOOP-16615. Add password check
for credential provider
URL: https://github.com/apache/hadoop/pull/1614#discussion_r333644230
 
 

 ##########
 File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/CredentialShell.java
 ##########
 @@ -86,6 +88,11 @@ protected int init(String[] args) throws IOException {
           return 1;
         }
         setSubCommand(new CreateCommand(args[++i]));
+      } else if (args[i].equals("check")) {
+        if (i == args.length -1) {
 
 Review comment:
   nit: add a space between - and 1 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message