hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] steveloughran commented on a change in pull request #1640: HADOOP-16637. Fix findbugs warnings in hadoop-cos.
Date Wed, 23 Oct 2019 16:29:54 GMT
steveloughran commented on a change in pull request #1640: HADOOP-16637. Fix findbugs warnings
in hadoop-cos.
URL: https://github.com/apache/hadoop/pull/1640#discussion_r338152515
 
 

 ##########
 File path: hadoop-cloud-storage-project/hadoop-cos/src/main/java/org/apache/hadoop/fs/cosn/CosNativeFileSystemStore.java
 ##########
 @@ -249,7 +250,15 @@ public void storeEmptyFile(String key) throws IOException {
 
   public PartETag uploadPart(File file, String key, String uploadId,
       int partNum) throws IOException {
-    InputStream inputStream = new FileInputStream(file);
+    InputStream inputStream = null;
 
 Review comment:
   looks broken, as L262 will always get a closed stream

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message