hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] steveloughran commented on issue #1671: HADOOP-16665. Filesystems to be closed if they failed during initialize().
Date Wed, 23 Oct 2019 18:52:07 GMT
steveloughran commented on issue #1671: HADOOP-16665. Filesystems to be closed if they failed
during initialize().
URL: https://github.com/apache/hadoop/pull/1671#issuecomment-545585572
 
 
   regression testing in progress. 
   
   I haven't written any tests to explicitly explore the new codepaths.
   
   I will probably add a new common test which has a mock file system that fails during init
and whose close() updates a static counter.
   
   Adding a test for S3A's explicit cleanup is a bit trickier. I could probably
   add an ITest which tried to create an FS with invalid settings -encryption
   ones get checked first- and then close() that after. This will at least show
   that the cleanup code is re-entrant.
   
   Trying to force a failure at a specific point after some closable items have been created
(instrumentation, thread pools etc) and verifying that these are null afterwards is going
to be very brittle. Avoid.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message