hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szilard Nemeth (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-16510) [hadoop-common] Fix order of actual and expected expression in assert statements
Date Thu, 31 Oct 2019 13:35:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964016#comment-16964016
] 

Szilard Nemeth commented on HADOOP-16510:
-----------------------------------------

Hi [~adam.antal]!
Thanks for this patch, very good job!

I found only 1 nit: I removed a commented out line in file: TestProtoBufRpc, from the imports:

{code:java}
// import org.junit.Assert;
{code}

+1, committing this to trunk!

[~adam.antal]: What about backporting this to branch-3.2 / branch-3.1?

Thanks!






> [hadoop-common] Fix order of actual and expected expression in assert statements
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-16510
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16510
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 3.2.0
>            Reporter: Adam Antal
>            Assignee: Adam Antal
>            Priority: Major
>         Attachments: HADOOP-16510.001.patch, HADOOP-16510.002.patch, HADOOP-16510.003.patch
>
>
> Fix order of actual and expected expression in assert statements which gives misleading
message when test case fails. Attached file has some of the places where it is placed wrongly.
> {code:java}
> [ERROR] testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService)
 Time elapsed: 3.385 s  <<< FAILURE!
> java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but was:<0>
> {code}
> For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be used for new
test cases which avoids such mistakes.
> This is a follow-up jira for the hadoop-common project.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message