hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] aajisaka commented on a change in pull request #2360: HDFS-15613. RBF: Router FSCK fails after HDFS-14442.
Date Tue, 06 Oct 2020 02:06:49 GMT

aajisaka commented on a change in pull request #2360:
URL: https://github.com/apache/hadoop/pull/2360#discussion_r499966438



##########
File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java
##########
@@ -1799,10 +1800,14 @@ public void satisfyStoragePolicy(String path) throws IOException {
   }
 
   @Override
-  public HAServiceProtocol.HAServiceState getHAServiceState()
-      throws IOException {
-    rpcServer.checkOperation(NameNode.OperationCategory.READ, false);
-    return null;
+  public HAServiceProtocol.HAServiceState getHAServiceState() {
+    try {
+      // check safemode or not
+      rpcServer.checkOperation(NameNode.OperationCategory.WRITE);

Review comment:
       Thank you for your comment. Updated the patch to just check the state instead of using
StandbyException.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message