hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HADOOP-17276) Extend CallerContext to make it include many items
Date Thu, 01 Oct 2020 12:03:00 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-17276?focusedWorklogId=493456&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-493456
]

ASF GitHub Bot logged work on HADOOP-17276:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Oct/20 12:02
            Start Date: 01/Oct/20 12:02
    Worklog Time Spent: 10m 
      Work Description: aajisaka commented on a change in pull request #2327:
URL: https://github.com/apache/hadoop/pull/2327#discussion_r498189901



##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
##########
@@ -114,6 +115,12 @@ public String toString() {
   /** The caller context builder. */
   public static final class Builder {
     private static final String KEY_VALUE_SEPARATOR = ":";
+    /**
+     * The illegal separators include '\t', '\n', '=', etc.
+     * User should not set illegal separator.
+     */
+    private static final List<String> ILLEGAL_SEPARATORS =
+        Arrays.asList("\t","\n","=");

Review comment:
       We should use `Collections.unmodifiableList` to provide an unmodifiable view.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 493456)
    Time Spent: 7h 20m  (was: 7h 10m)

> Extend CallerContext to make it include many items
> --------------------------------------------------
>
>                 Key: HADOOP-17276
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17276
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Hui Fei
>            Assignee: Hui Fei
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 7h 20m
>  Remaining Estimate: 0h
>
> Now context is string. We need to extend the CallerContext because context may contains
many items.
> Items include 
> * router ip
> * MR or CLI
> * etc



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message