hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ayush Saxena (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-17288) Use shaded guava from thirdparty
Date Tue, 06 Oct 2020 09:33:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-17288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208607#comment-17208607
] 

Ayush Saxena commented on HADOOP-17288:
---------------------------------------

[~stack] The guava I planned to revert to 11 as of now, that would be used by the dependencies
only, Not by the hadoop code, and people including hadoop dependencies will have a choice
to exclude this {{Gauva-11}} if they themselves have guava. So, I think it should be safe?
The dependencies also doesn't seems to be very specific with the version, as {{curator}} has
already shaded {{gauva}} apart from 3-4 files, for which we need guava, and those files are
quite stable, there are couple of more dependencies which use guava, they also doesn't seems
to create much issues. All tests passed with {{{gauva-11}} and {{guava-27}} as well. 

So, I prefer staying at {{guava-11}}. Let me know your thoughts?
Plan to address [~vinayakumarb] comments by tomorrow,  once you confirm. Thanx..

> Use shaded guava from thirdparty
> --------------------------------
>
>                 Key: HADOOP-17288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17288
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Ayush Saxena
>            Assignee: Ayush Saxena
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Use the shaded version of guava in hadoop-thirdparty



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message