From common-issues-return-207721-apmail-hadoop-common-issues-archive=hadoop.apache.org@hadoop.apache.org Thu Oct 1 12:04:34 2020 Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@locus.apache.org Delivered-To: apmail-hadoop-common-issues-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 07B471A02C for ; Thu, 1 Oct 2020 12:04:34 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id A84B012373B for ; Thu, 1 Oct 2020 12:04:33 +0000 (UTC) Received: (qmail 41001 invoked by uid 500); 1 Oct 2020 12:04:33 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 40938 invoked by uid 500); 1 Oct 2020 12:04:33 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 40891 invoked by uid 99); 1 Oct 2020 12:04:33 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Oct 2020 12:04:33 +0000 From: =?utf-8?q?GitBox?= To: common-issues@hadoop.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bhadoop=5D_aajisaka_commented_on_a_change_in_pull_r?= =?utf-8?q?equest_=232327=3A_HADOOP-17276=2E_Extend_CallerContext_to_make_it?= =?utf-8?q?_include_many_items?= Message-ID: <160155387301.32230.11436144769360990119.asfpy@gitbox.apache.org> Date: Thu, 01 Oct 2020 12:04:33 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: aajisaka commented on a change in pull request #2327: URL: https://github.com/apache/hadoop/pull/2327#discussion_r498191019 ########## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java ########## @@ -114,6 +115,12 @@ public String toString() { /** The caller context builder. */ public static final class Builder { private static final String KEY_VALUE_SEPARATOR = ":"; + /** + * The illegal separators include '\t', '\n', '=', etc. Review comment: > , etc. The illegal separators are only `\t`, `\n`, and `=`. "etc" is not needed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org