From common-issues-return-207770-apmail-hadoop-common-issues-archive=hadoop.apache.org@hadoop.apache.org Thu Oct 1 20:19:53 2020 Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@locus.apache.org Delivered-To: apmail-hadoop-common-issues-archive@locus.apache.org Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by minotaur.apache.org (Postfix) with ESMTP id BA3B91A20D for ; Thu, 1 Oct 2020 20:19:53 +0000 (UTC) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id B9ABB64D56 for ; Thu, 1 Oct 2020 20:19:52 +0000 (UTC) Received: (qmail 97126 invoked by uid 500); 1 Oct 2020 20:19:51 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 97049 invoked by uid 500); 1 Oct 2020 20:19:51 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 97033 invoked by uid 99); 1 Oct 2020 20:19:51 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Oct 2020 20:19:51 +0000 From: =?utf-8?q?GitBox?= To: common-issues@hadoop.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bhadoop=5D_steveloughran_commented_on_a_change_in_p?= =?utf-8?q?ull_request_=232349=3A_MAPREDUCE-7282=2E_Move_away_from_V2_commit?= =?utf-8?q?_algorithm?= Message-ID: <160158359118.32230.9123002375359728330.asfpy@gitbox.apache.org> Date: Thu, 01 Oct 2020 20:19:51 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: steveloughran commented on a change in pull request #2349: URL: https://github.com/apache/hadoop/pull/2349#discussion_r498491655 ########## File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/FileOutputCommitter.java ########## @@ -348,6 +348,16 @@ public Path getWorkPath() throws IOException { * @param context the job's context */ public void setupJob(JobContext context) throws IOException { + // Downgrade v2 to v1 with a warning. + if (algorithmVersion == 2) { + Logger log = LoggerFactory.getLogger( + "org.apache.hadoop.mapreduce.lib.output." + + "FileOutputCommitter.Algorithm"); + + log.warn("The v2 commit algorithm is deprecated;" + + " please switch to the v1 algorithm"); Review comment: switching to your text ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org