hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] snvijaya commented on a change in pull request #3026: HADOOP-17590 ABFS: Introduce Lease Operations with Append to provide single writer semantics
Date Wed, 02 Jun 2021 10:46:42 GMT

snvijaya commented on a change in pull request #3026:
URL: https://github.com/apache/hadoop/pull/3026#discussion_r643840786



##########
File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
##########
@@ -506,13 +506,15 @@ public OutputStream createFile(final Path path,
         triggerConditionalCreateOverwrite = true;
       }
 
+      AbfsLease lease = maybeCreateFiniteLease(relativePath, isNamespaceEnabled);

Review comment:
       If the path qualifies for infinteLease as per config settings, this will still create
a finite lease ? 
   
   Call to a method createLease() that will first check for infiniteLease setting before defaulting
to finite lease (if write lease config is enabled), would be the expectation ? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message