hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] snvijaya commented on a change in pull request #3026: HADOOP-17590 ABFS: Introduce Lease Operations with Append to provide single writer semantics
Date Wed, 02 Jun 2021 10:48:15 GMT

snvijaya commented on a change in pull request #3026:
URL: https://github.com/apache/hadoop/pull/3026#discussion_r643841953



##########
File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
##########
@@ -521,12 +523,14 @@ public OutputStream createFile(final Path path,
             isNamespaceEnabled ? getOctalNotation(permission) : null,
             isNamespaceEnabled ? getOctalNotation(umask) : null,
             isAppendBlob,
-            null);
+            null,
+            lease);
       }
       perfInfo.registerResult(op.getResult()).registerSuccess(true);
 
-      AbfsLease lease = maybeCreateLease(relativePath);
-
+      if (lease == null) {

Review comment:
       Acquiring lease along with create/append enables atomic fetch of lease with the store
operation and prevent any parallel writers. If configured for infinite lease, the path creation
will happen without bundled lease acquiry and rely on later acquireLease API call in AbfsLease.

   AbfsLease background acquireLease should be scheduled post lease is acquired along with
create API (bundled) ? Infinite lease flow purely on acquireLease API should be the case only
if fs.azure.write.enforceLease is off.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message