hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HADOOP-17631) Configuration ${env.VAR:-FALLBACK} should eval FALLBACK when restrictSystemProps=true
Date Tue, 01 Jun 2021 07:50:00 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-17631?focusedWorklogId=604356&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-604356
]

ASF GitHub Bot logged work on HADOOP-17631:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Jun/21 07:49
            Start Date: 01/Jun/21 07:49
    Worklog Time Spent: 10m 
      Work Description: mukund-thakur commented on pull request #2977:
URL: https://github.com/apache/hadoop/pull/2977#issuecomment-851907260


   The logic is bit complex but as far as I understand looks good to me. +1 
   Nice tests as well. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 604356)
    Time Spent: 50m  (was: 40m)

> Configuration ${env.VAR:-FALLBACK} should eval FALLBACK when restrictSystemProps=true

> --------------------------------------------------------------------------------------
>
>                 Key: HADOOP-17631
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17631
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: common
>    Affects Versions: 3.3.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> When configuration reads in resources with a restricted parser, it skips evaluaging system
${env. } vars. But it also skips evaluating fallbacks
> As a result, a property like
> ${env.LOCAL_DIRS:-${hadoop.tmp.dir}} ends up evaluating as ${env.LOCAL_DIRS:-${hadoop.tmp.dir}}
> It should instead fall back to the "env var unset" option of ${hadoop.tmp.dir}. This
allows for configs (like for s3a buffer dirs) which are usable in restricted mode as well
as unrestricted deployments.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message