From mapreduce-commits-return-266-apmail-hadoop-mapreduce-commits-archive=hadoop.apache.org@hadoop.apache.org Mon Sep 14 17:14:54 2009 Return-Path: Delivered-To: apmail-hadoop-mapreduce-commits-archive@minotaur.apache.org Received: (qmail 92740 invoked from network); 14 Sep 2009 17:14:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 14 Sep 2009 17:14:54 -0000 Received: (qmail 463 invoked by uid 500); 14 Sep 2009 17:14:54 -0000 Delivered-To: apmail-hadoop-mapreduce-commits-archive@hadoop.apache.org Received: (qmail 416 invoked by uid 500); 14 Sep 2009 17:14:54 -0000 Mailing-List: contact mapreduce-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-dev@hadoop.apache.org Delivered-To: mailing list mapreduce-commits@hadoop.apache.org Received: (qmail 401 invoked by uid 99); 14 Sep 2009 17:14:54 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Sep 2009 17:14:54 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Sep 2009 17:14:52 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 340F323888A2; Mon, 14 Sep 2009 17:14:32 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r814738 - in /hadoop/mapreduce/trunk: CHANGES.txt src/tools/org/apache/hadoop/tools/HadoopArchives.java Date: Mon, 14 Sep 2009 17:14:32 -0000 To: mapreduce-commits@hadoop.apache.org From: mahadev@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090914171432.340F323888A2@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: mahadev Date: Mon Sep 14 17:14:31 2009 New Revision: 814738 URL: http://svn.apache.org/viewvc?rev=814738&view=rev Log: MAPREDUCE-826. harchive doesn't use ToolRunner / harchive returns 0 even if the job fails with exception (koji Noguchi via mahadev) Modified: hadoop/mapreduce/trunk/CHANGES.txt hadoop/mapreduce/trunk/src/tools/org/apache/hadoop/tools/HadoopArchives.java Modified: hadoop/mapreduce/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/hadoop/mapreduce/trunk/CHANGES.txt?rev=814738&r1=814737&r2=814738&view=diff ============================================================================== --- hadoop/mapreduce/trunk/CHANGES.txt (original) +++ hadoop/mapreduce/trunk/CHANGES.txt Mon Sep 14 17:14:31 2009 @@ -584,3 +584,7 @@ MAPREDUCE-968. NPE in distcp encountered when placing _logs directory on S3FileSystem. (Aaron Kimball via tomwhite) + + MAPREDUCE-826. harchive doesn't use ToolRunner / harchive returns 0 even + if the job fails with exception (koji Noguchi via mahadev) + Modified: hadoop/mapreduce/trunk/src/tools/org/apache/hadoop/tools/HadoopArchives.java URL: http://svn.apache.org/viewvc/hadoop/mapreduce/trunk/src/tools/org/apache/hadoop/tools/HadoopArchives.java?rev=814738&r1=814737&r2=814738&view=diff ============================================================================== --- hadoop/mapreduce/trunk/src/tools/org/apache/hadoop/tools/HadoopArchives.java (original) +++ hadoop/mapreduce/trunk/src/tools/org/apache/hadoop/tools/HadoopArchives.java Mon Sep 14 17:14:31 2009 @@ -744,11 +744,16 @@ public static void main(String[] args) { JobConf job = new JobConf(HadoopArchives.class); HadoopArchives harchives = new HadoopArchives(job); - try { - int res = harchives.run(args); - System.exit(res); + int ret = 0; + + try{ + ret = ToolRunner.run(harchives, args); } catch(Exception e) { + LOG.debug("Exception in archives ", e); + System.err.println("Exception in archives"); System.err.println(e.getLocalizedMessage()); + System.exit(1); } + System.exit(ret); } }