hadoop-mapreduce-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Plamen Jeliazkov" <pjeliaz...@ebay.com>
Subject Re: Review Request: Addition of 3 new examples -- WordMean, WordMedian, and WordStandardDeviation
Date Thu, 21 Jul 2011 01:30:47 GMT


> On 2011-07-19 14:58:10, Harsh J wrote:
> > http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.22/mapreduce/src/examples/org/apache/hadoop/examples/WordMedian.java,
line 185
> > <https://reviews.apache.org/r/1091/diff/4/?file=26229#file26229line185>
> >
> >     If this class is public, use its .class.getCanonicalName() method directly via
an import itself?
> >     
> >     Also, I though there were public counter enum groups available. Look for those
instead of fetching w/ strings, and if they don't exist then this is fine.
> 
> Plamen Jeliazkov wrote:
>     I just removed this entirely. I am using the .findCounter(Str,Str) method directly
instead.

I realized I cannot just do that -- I could not find a stable way to use the public counter
enum groups to get the MAP_OUTPUT_RECORDS. I know it was supposed to be fixed in 0.21.0, but
I still feel like it is not easily accessed. For completion I have decided to just use your
first idea with the .class.getCanonicalName() method.


- Plamen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1091/#review1109
-----------------------------------------------------------


On 2011-07-18 23:26:12, Plamen Jeliazkov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1091/
> -----------------------------------------------------------
> 
> (Updated 2011-07-18 23:26:12)
> 
> 
> Review request for hadoop-mapreduce.
> 
> 
> Summary
> -------
> 
> Looking to add 3 new examples -- they can be added via the diff attached; some changes
to the ExamplesDriver.java might be required however these files do work alone as well. I
will also be attaching JUnit tests for these examples. I will post another review request
for those.
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.22/mapreduce/src/test/mapred/org/apache/hadoop/examples/TestWordStandardDeviation.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.22/mapreduce/src/test/mapred/org/apache/hadoop/examples/input/shaks12.txt
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.22/mapreduce/src/examples/org/apache/hadoop/examples/WordMedian.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.22/mapreduce/src/examples/org/apache/hadoop/examples/WordStandardDeviation.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.22/mapreduce/src/test/mapred/org/apache/hadoop/examples/TestWordMean.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.22/mapreduce/src/test/mapred/org/apache/hadoop/examples/TestWordMedian.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.22/mapreduce/src/examples/org/apache/hadoop/examples/WordMean.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/1091/diff
> 
> 
> Testing
> -------
> 
> JUnit tests added -- reduced to 3 tests that all read from an input folder.
> 
> 
> Thanks,
> 
> Plamen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message