hadoop-yarn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Roger Hoover <roger.hoo...@gmail.com>
Subject Re: Help submitting a patch (test timeouts)
Date Sat, 23 Feb 2013 22:43:20 GMT
Thank you, Steve.  I tend to agree that timeouts in test code are brittle
b/c they're very sensitive to the environment in which the test is
executed.


On Sat, Feb 23, 2013 at 10:45 AM, Steve Loughran <stevel@hortonworks.com>wrote:

> A change went in to the patch reviewer that now requires an timeout
> attribute, so as to ensure better handling of timing out tests on Jenkins
>
> https://issues.apache.org/jira/browse/HADOOP-9112
>
> I am one of the people who think that hard coding timeouts is the wrong
> solution to this problem. For now: either add a (timeout=) declaration in
> the @Test attribute, or post a reason justifying why it should be left out.
>
> On 21 February 2013 21:28, Roger Hoover <roger.hoover@gmail.com> wrote:
>
> > Hi,
> >
> > I'm trying to submit a patch for a "simple" bug fix.
> >
> > https://issues.apache.org/jira/browse/YARN-412
> >
> > The Hudson build bot is complaining that one of the included tests does
> not
> > have a timeout.  I've added a timeout to the test case that I added
> (using
> > @Test(timeout=2000)) but it still complains.
> >
> > Do I need to add timeouts to the exist test cases in the same file that I
> > did not modify?
> >
> > Cheers,
> >
> > Roger
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message