From yarn-dev-return-973-apmail-hadoop-yarn-dev-archive=hadoop.apache.org@hadoop.apache.org Sat Feb 23 18:45:51 2013 Return-Path: X-Original-To: apmail-hadoop-yarn-dev-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 72E30EB71 for ; Sat, 23 Feb 2013 18:45:51 +0000 (UTC) Received: (qmail 93006 invoked by uid 500); 23 Feb 2013 18:45:51 -0000 Delivered-To: apmail-hadoop-yarn-dev-archive@hadoop.apache.org Received: (qmail 92948 invoked by uid 500); 23 Feb 2013 18:45:50 -0000 Mailing-List: contact yarn-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-dev@hadoop.apache.org Delivered-To: mailing list yarn-dev@hadoop.apache.org Received: (qmail 92938 invoked by uid 99); 23 Feb 2013 18:45:50 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Feb 2013 18:45:50 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of stevel@hortonworks.com designates 209.85.128.178 as permitted sender) Received: from [209.85.128.178] (HELO mail-ve0-f178.google.com) (209.85.128.178) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Feb 2013 18:45:43 +0000 Received: by mail-ve0-f178.google.com with SMTP id db10so1398211veb.37 for ; Sat, 23 Feb 2013 10:45:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:content-type:x-gm-message-state; bh=QeDFyCtPkh88ZqWqBs6sB5yRLnT1w98m0nyhBRaJMo8=; b=K9YX2IsD5wI43g47vS9NpBSdZgIZENedAPC1+mNwArftZv7cn/ygz9yM9bLuf5Xx2w lpBZqNWenMNbfgk1wQ/kqhC5vxHh68SIvUPu99qH12+vifI9hbxLTY1i5dSPzeg++rdV nLyM1Y7yQKubcY+RLxo3LNjSIFOpmpPTB80LvjocKW0fRiPHxh/Bch8vAAJQ4o5Urc8V 0UCvTgctCLHiHqjvhKfnZGFqeh2UEF3Hud8nvFzji/c5IJtP1nEY33itxJw96WOhVm+p eHhwmgYuPhAHJpSJTPrrrKaw86gto1p6hlKSfL53Mohqe4NcNSgUuSfrxTRBwQjdalHp cgrA== MIME-Version: 1.0 X-Received: by 10.52.36.194 with SMTP id s2mr6781784vdj.119.1361645122470; Sat, 23 Feb 2013 10:45:22 -0800 (PST) Received: by 10.58.239.103 with HTTP; Sat, 23 Feb 2013 10:45:22 -0800 (PST) In-Reply-To: References: Date: Sat, 23 Feb 2013 18:45:22 +0000 Message-ID: Subject: Re: Help submitting a patch (test timeouts) From: Steve Loughran To: yarn-dev@hadoop.apache.org Content-Type: multipart/alternative; boundary=20cf307c9fc0d5c2af04d668b564 X-Gm-Message-State: ALoCoQkEW2Pv8QQ7uwUf8jc4B0IKX8tkt8mPLTWIs5DjfltHCSiisz/AROyXIRpncJXbEK8z7Lg2 X-Virus-Checked: Checked by ClamAV on apache.org --20cf307c9fc0d5c2af04d668b564 Content-Type: text/plain; charset=UTF-8 A change went in to the patch reviewer that now requires an timeout attribute, so as to ensure better handling of timing out tests on Jenkins https://issues.apache.org/jira/browse/HADOOP-9112 I am one of the people who think that hard coding timeouts is the wrong solution to this problem. For now: either add a (timeout=) declaration in the @Test attribute, or post a reason justifying why it should be left out. On 21 February 2013 21:28, Roger Hoover wrote: > Hi, > > I'm trying to submit a patch for a "simple" bug fix. > > https://issues.apache.org/jira/browse/YARN-412 > > The Hudson build bot is complaining that one of the included tests does not > have a timeout. I've added a timeout to the test case that I added (using > @Test(timeout=2000)) but it still complains. > > Do I need to add timeouts to the exist test cases in the same file that I > did not modify? > > Cheers, > > Roger > --20cf307c9fc0d5c2af04d668b564--