hadoop-yarn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aki Tanaka (JIRA)" <j...@apache.org>
Subject [jira] [Created] (YARN-8840) Add missing cleanupSSLConfig() call for TestTimelineClient test
Date Tue, 02 Oct 2018 23:40:00 GMT
Aki Tanaka created YARN-8840:
--------------------------------

             Summary: Add missing cleanupSSLConfig() call for TestTimelineClient test
                 Key: YARN-8840
                 URL: https://issues.apache.org/jira/browse/YARN-8840
             Project: Hadoop YARN
          Issue Type: Bug
          Components: test, timelineclient
            Reporter: Aki Tanaka


Tests that setup SSLConfigs can leave conf-files lingering unless they are cleaned up via {{KeyStoreTestUtil.cleanupSSLConfig}} call.
TestTimelineClient test is missing this call.

If the cleanup method is not called explicitly, a modified ssl-client.xml is left in {{test-classes}},
might affect subsequent test cases.

 

There was a similar report in HDFS-11042, but looks that we need to fix TestTimelineClient
test too.

 
{code:java}
$ mvn test -Dtest=TestTimelineClient
$ find .|grep ssl-client.xml$
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/target/test-classes/ssl-client.xml
$ cat ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/target/test-classes/ssl-client.xml
<?xml version="1.0" encoding="UTF-8" standalone="no"?><configuration>
<property><name>ssl.client.truststore.reload.interval</name><value>1000</value><final>false</final><source>programmatically</source></property>
<property><name>ssl.client.truststore.location</name><value>/Users/tanaka/work/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/target/test-dir/trustKS.jks</value><final>false</final><source>programmatically</source></property>
<property><name>ssl.client.keystore.keypassword</name><value>clientP</value><final>false</final><source>programmatically</source></property>
<property><name>ssl.client.keystore.location</name><value>/Users/tanaka/work/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/target/test-dir/clientKS.jks</value><final>false</final><source>programmatically</source></property>
<property><name>ssl.client.truststore.password</name><value>trustP</value><final>false</final><source>programmatically</source></property>
<property><name>ssl.client.keystore.password</name><value>clientP</value><final>false</final><source>programmatically</source></property>
{code}
 

After applying this patch, the ssl-client.xml is not generated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-dev-help@hadoop.apache.org


Mime
View raw message