From yarn-dev-return-31642-apmail-hadoop-yarn-dev-archive=hadoop.apache.org@hadoop.apache.org Fri Oct 19 14:23:02 2018 Return-Path: X-Original-To: apmail-hadoop-yarn-dev-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 80982182D4 for ; Fri, 19 Oct 2018 14:23:02 +0000 (UTC) Received: (qmail 19279 invoked by uid 500); 19 Oct 2018 14:23:02 -0000 Delivered-To: apmail-hadoop-yarn-dev-archive@hadoop.apache.org Received: (qmail 19187 invoked by uid 500); 19 Oct 2018 14:23:02 -0000 Mailing-List: contact yarn-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-dev@hadoop.apache.org Received: (qmail 19175 invoked by uid 99); 19 Oct 2018 14:23:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Oct 2018 14:23:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9C4DE1A05FF for ; Fri, 19 Oct 2018 14:23:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id lTewC2l13uaw for ; Fri, 19 Oct 2018 14:23:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E7A8D5F433 for ; Fri, 19 Oct 2018 14:23:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 80D69E0E87 for ; Fri, 19 Oct 2018 14:23:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 41A4125290 for ; Fri, 19 Oct 2018 14:23:00 +0000 (UTC) Date: Fri, 19 Oct 2018 14:23:00 +0000 (UTC) From: "Zhankun Tang (JIRA)" To: yarn-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (YARN-8918) [Submarine] Remove redundant method of str.subString(0, str.length()) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Zhankun Tang created YARN-8918: ---------------------------------- Summary: [Submarine] Remove redundant method of str.subString(0, str.length()) Key: YARN-8918 URL: https://issues.apache.org/jira/browse/YARN-8918 Project: Hadoop YARN Issue Type: Sub-task Reporter: Zhankun Tang In CliUtils.java (line 74), there's redundant code block that can be removed: {code:java} if (resourcesStr.endsWith("]")) { resourcesStr = resourcesStr.substring(0, resourcesStr.length()); }{code} Above if block will execute "resourceStr = resourceStr". -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-dev-help@hadoop.apache.org