From yarn-dev-return-31696-apmail-hadoop-yarn-dev-archive=hadoop.apache.org@hadoop.apache.org Mon Oct 29 12:34:11 2018 Return-Path: X-Original-To: apmail-hadoop-yarn-dev-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A832C18CD2 for ; Mon, 29 Oct 2018 12:34:11 +0000 (UTC) Received: (qmail 52477 invoked by uid 500); 29 Oct 2018 12:34:11 -0000 Delivered-To: apmail-hadoop-yarn-dev-archive@hadoop.apache.org Received: (qmail 52243 invoked by uid 500); 29 Oct 2018 12:34:10 -0000 Mailing-List: contact yarn-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-dev@hadoop.apache.org Received: (qmail 52104 invoked by uid 99); 29 Oct 2018 12:34:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Oct 2018 12:34:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 5D0EBC0C69 for ; Mon, 29 Oct 2018 12:34:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id NQRpFFhjl7jp for ; Mon, 29 Oct 2018 12:34:09 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 803265F48E for ; Mon, 29 Oct 2018 12:34:08 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D2900E0A31 for ; Mon, 29 Oct 2018 12:34:07 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7E0C827762 for ; Mon, 29 Oct 2018 12:34:07 +0000 (UTC) Date: Mon, 29 Oct 2018 12:34:07 +0000 (UTC) From: "Szilard Nemeth (JIRA)" To: yarn-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (YARN-8951) Defining default queue placement rule in allocations file with create="false" throws an NPE MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Szilard Nemeth created YARN-8951: ------------------------------------ Summary: Defining default queue placement rule in allocations = file with create=3D"false" throws an NPE Key: YARN-8951 URL: https://issues.apache.org/jira/browse/YARN-8951 Project: Hadoop YARN Issue Type: Bug Reporter: Szilard Nemeth Assignee: Szilard Nemeth Attachments: default-placement-rule-with-create-false.patch If the default queue placement rule is defined with {{create=3D"false"}}=C2= =A0and a scheduling request is created=C2=A0for queue {{"root.default"}}, t= hen {{FairScheduler#assignToQueue}} throws an NPE, while trying to construc= t an error message in the catch block of {{IllegalStateException}}, relying= on the fact that the {{rmApp}} is not null but it is. Example of such a config file: {code:java} =09 =09=091024mb,0vcores =09 =09 =09=09 =09 {code} This is suspicious, as there are some null checks for {{rmApp}} in=C2=A0the= same=C2=A0method. Not sure if this is a special case for the tests or it is reproducable in = a cluster, this needs further investigation. In any case, it's not good that we try to dereference the {{rmApp}} that is= null. On the other hand, I'm not sure if the default queue placement rule with {{= create=3D"false"}}=C2=A0makes sense at all. Looking at the documentation ([= https://hadoop.apache.org/docs/r3.1.0/hadoop-yarn/hadoop-yarn-site/FairSche= duler.html):] {quote}default: the app is placed into the queue specified in the =E2=80=98= queue=E2=80=99 attribute of the default rule. *If =E2=80=98queue=E2=80=99 a= ttribute is not specified, the app is placed into =E2=80=98root.default=E2= =80=99 queue.* A queuePlacementPolicy element: which contains a list of rule elements that= tell the scheduler how to place incoming apps into queues. Rules are appli= ed in the order that they are listed. Rules may take arguments. *All rules = accept the =E2=80=9Ccreate=E2=80=9D argument, which indicates whether the r= ule can create a new queue. =E2=80=9CCreate=E2=80=9D defaults to true; if s= et to false and the rule would place the app in a queue that is not configu= red in the allocations file, we continue on to the next rule.* The last rul= e must be one that can never issue a continue.... {quote} In this case, the rule has the queue property suppressed so the apps should= be placed to the=C2=A0{{root.default}} queue (which is an undefined queue = according to the config file), and create is false, meaning that the queue= =C2=A0{{root.default}} cannot be created at all. *This seems to be a case of an invalid queue configuration file for me.* [~jlowe], [~leftnoteasy]: What is your take on this? =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-dev-help@hadoop.apache.org