hadoop-yarn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Bacsko (JIRA)" <j...@apache.org>
Subject [jira] [Created] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin
Date Fri, 01 Feb 2019 11:59:00 GMT
Peter Bacsko created YARN-9266:
----------------------------------

             Summary: Various fixes are needed in IntelFpgaOpenclPlugin
                 Key: YARN-9266
                 URL: https://issues.apache.org/jira/browse/YARN-9266
             Project: Hadoop YARN
          Issue Type: Sub-task
            Reporter: Peter Bacsko


Problems identified in this class:

* InnerShellExecutor ignores the timeout parameter
* configureIP() uses printStackTrace() instead of logging
* configureIP() does not log the output of aocl if the exit code != 0
* parseDiagnoseInfo() is too heavyweight -- it should be in its own class for better testability
* downloadIP() uses contains() for file name check -- this can really surprise users in some
cases (eg. you want to use hello.aocx but hello2.aocx also matches)
* method name downloadIP() is misleading -- it actually tries to finds the file. Everything
is downloaded (localized) at this point.
* @VisibleForTesting methods should be package private



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-dev-help@hadoop.apache.org


Mime
View raw message