hadoop-yarn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Bacsko (JIRA)" <j...@apache.org>
Subject [jira] [Created] (YARN-9270) Minor cleanup in TestFpgaDiscoverer
Date Fri, 01 Feb 2019 12:34:00 GMT
Peter Bacsko created YARN-9270:
----------------------------------

             Summary: Minor cleanup in TestFpgaDiscoverer
                 Key: YARN-9270
                 URL: https://issues.apache.org/jira/browse/YARN-9270
             Project: Hadoop YARN
          Issue Type: Sub-task
            Reporter: Peter Bacsko


Let's do some cleanup in this class.

* {{testLinuxFpgaResourceDiscoverPluginConfig}} - this test should be split up to 5 different
tests, because it tests 5 different scenarios.
* remove {{setNewEnvironmentHack()}} - too complicated. We can introduce a {{Function}} in
the plugin class like {{Function<String, String> envProvider = System::getenv()}} plus
a setter method which allows the test to modify {{envProvider}}. Much simpler and straightfoward.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-dev-help@hadoop.apache.org


Mime
View raw message