hadoop-yarn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steve Loughran <ste...@cloudera.com.INVALID>
Subject Re: [DISCUSS] Use of AssertJ for testing
Date Thu, 04 Apr 2019 20:48:37 GMT
assertj is already on the test classpath for some modules already, though
an older version (3.8.0) from what's current (3.12.0)

No problems seem to have surfaced, so I don't see anything wrong with
picking it up more broadly.

if someone wants to update the assertj version, it's only a test artifact
so no worries about that



On Mon, Apr 1, 2019 at 5:37 AM Akira Ajisaka <aajisaka@apache.org> wrote:

> Hi folks,
>
> Now I'm going to upgrade the JUnit version from 4 to 5 for Java 11 support.
> I wanted to start with the small module, so I uploaded a patch to upgrade
> the API in hadoop-yarn-api module at first (YARN-8943), and in this JIRA,
> Szilard Nemeth suggested using AssertJ with JUnit 5. (Thanks Szilard
> for the suggestion!)
>
> I think the JUnit upgrade and the use of AssertJ are separated, but
> related tasks.
> Therefore, I'd like to decide:
> - Use AssertJ or not
> - If we are going to use AssertJ, when to use AssertJ (before
> upgrading JUnit or after?)
>
> My opinion is:
> - JUnit migration is required for Java 11, so upgrading JUnit as soon
> as possible.
> - After the migration, we may use AssertJ for existing tests.
> - We may use AssertJ for new tests. (not must)
>
> Any thoughts?
>
> Thanks,
> Akira
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message