hadoop-yarn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akira Ajisaka <aajis...@apache.org>
Subject Re: [DISCUSS] Use of AssertJ for testing
Date Thu, 11 Apr 2019 09:09:33 GMT
Thank you for the discussion.
I didn't know that assertj is already on the test classpath for some modules.

>  I think it'd be good to make the new tests Junit 5+ aspect, rather than mixed, as it'll
confuse backporting a lot.
+1 for the idea.

Here is a summary:

- Let's upgrade the existing tests to JUnit 5.
- It's good to make the new tests using JUnit 5.
- We may use AssertJ and update the version.

Any thoughts?
If there are no objections, let's start with YARN-8943.

Thanks,
Akira

On Tue, Apr 9, 2019 at 7:06 AM Anu Engineer <aengineer@hortonworks.com> wrote:
>
> +1, on AssertJ usage, thanks for getting this done.
> --Anu
>
>
> On 3/31/19, 9:37 PM, "Akira Ajisaka" <aajisaka@apache.org> wrote:
>
>     Hi folks,
>
>     Now I'm going to upgrade the JUnit version from 4 to 5 for Java 11 support.
>     I wanted to start with the small module, so I uploaded a patch to upgrade
>     the API in hadoop-yarn-api module at first (YARN-8943), and in this JIRA,
>     Szilard Nemeth suggested using AssertJ with JUnit 5. (Thanks Szilard
>     for the suggestion!)
>
>     I think the JUnit upgrade and the use of AssertJ are separated, but
>     related tasks.
>     Therefore, I'd like to decide:
>     - Use AssertJ or not
>     - If we are going to use AssertJ, when to use AssertJ (before
>     upgrading JUnit or after?)
>
>     My opinion is:
>     - JUnit migration is required for Java 11, so upgrading JUnit as soon
>     as possible.
>     - After the migration, we may use AssertJ for existing tests.
>     - We may use AssertJ for new tests. (not must)
>
>     Any thoughts?
>
>     Thanks,
>     Akira
>
>     ---------------------------------------------------------------------
>     To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
>     For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-dev-help@hadoop.apache.org


Mime
View raw message