hadoop-yarn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szilard Nemeth (JIRA)" <j...@apache.org>
Subject [jira] [Created] (YARN-9680) Code cleanup in ResourcePluginManager init methods
Date Mon, 15 Jul 2019 14:51:00 GMT
Szilard Nemeth created YARN-9680:
------------------------------------

             Summary: Code cleanup in ResourcePluginManager init methods
                 Key: YARN-9680
                 URL: https://issues.apache.org/jira/browse/YARN-9680
             Project: Hadoop YARN
          Issue Type: Improvement
            Reporter: Szilard Nemeth


We have 2 initializer methods in this class: 
1. org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.ResourcePluginManager#initialize
2. org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.ResourcePluginManager#initializePluggableDevicePlugins

Both are overly complex, contains nested conditions / loops.
A simple refactor could be performed (along with tests) on these methods, for example, by
splitting them into smaller methods, as a start.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-dev-help@hadoop.apache.org


Mime
View raw message