hadoop-yarn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sunil Govindan <sun...@apache.org>
Subject Re: Thoughts about moving submarine to a separate git repo?
Date Fri, 16 Aug 2019 08:42:14 GMT
Hi Xun,

Thanks for the proposal. Altogether this proposal makes sense to me.

IIUC, an external repo is created and developers found more productive in
that because of faster reviews and commits.
To do more this apache way,
1. I think its better we track all this in apache jira (apparently this is
already happening, thanks for that).
2. In apache, we have a provision called branch committer. This role will
help to drive a feature ('s) in a branch cut from apache trunk,
and selected branch committers can push changes to apache repo. Thus fast
pacing feature development in community.
So nominating couple of active contributors of submarine for branch
committership could address the concerns raised by you above.

For this part, only difference I see is about a new repo instead of branch
from Apache trunk.
AFAIK, This seems not a stopper for the branch committership suggestion
(please correct me if I am wrong).
However we need to ensure that commit rights of that repo is only available
branch committer's and all apache policies are adhered in that.

Overall I feel option #2 mentioned above is a good way to proceed further.
Welcoming thoughts from others who have more contexts into similar past


On Fri, Aug 16, 2019 at 10:13 AM Xun Liu <liuxun@apache.org> wrote:

> Dear Submarine developers,
> My name is Xun Liu, I am a member of the Hadoop submarine development team.
> I'm one of the major contributor of Submarine since June 2018.
> I want to hear your thoughts about creating a separate GitHub repo under
> Apache to do submarine development. This is an independent effort of
> Submarine spin-off from the Hadoop project [
> https://lists.apache.org/thread.html/3fab657f905d081b536d9081dc404f7fd20c80eb824c857bc8e16e3b@
> <submarine-dev.hadoop.apache.org>].
> However, once the spin-off is approved, this effort can benefit the
> follow-up processes as well.
> Submarine dev community has a total of 8 developers and submits an average
> of 4 to 5 PR per day.
> But there are a limited number of Hadoop committer actively help review and
> merge patches, which causes development progress delays.
> So we created an external GitHub repo [
> https://github.com/hadoopsubmarine/submarine] and moved all the code for
> the Hadoop submarine project into the external Github repo.
> In this way, everyone can review the code for each other, and now the
> development progress of Hadoop submarine is very fast.
> Also, now Submarine has little dependency on Hadoop, we want to have a
> separate CI/CD pipeline to release and test submarine instead of every time
> build whole Hadoop. Putting Submarine under Hadoop will introduce
> unnecessary dependencies to Hadoop's top-level pom.xml.
> Our development process still complies with the development rules of the
> Hadoop community: first, create a ticket in the submarine JIRA, and then
> develop, in the external GitHub repo repository, the title of each PR will
> be accompanied by the JIRA ID number.
> Once the Apache Github repo is created, we going to move all external
> commits to the new Apache Github repo.
> Any suggestions are welcome!
> Best Regards
> Xun Liu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message