hadoop-yarn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akira Ajisaka <aajis...@apache.org>
Subject Re: Precommit job fails to write comments in the GitHub pull requests
Date Mon, 05 Oct 2020 01:18:38 GMT
Hi Mastake and Ayush,

After YETUS-994, Yetus updates the commit status instead of writing a comment.
Now I think Yetus still fail to update the commit status, however, now
Jenkins can successfully update the commit status instead and the
result is shown in the link.
Example: https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-2278/11/pipeline/
Isn't it work for you?

> I prefer using fixed/static version of toolchain in order to avoid surprising the developers.
Agreed, but now there is no way to run javadoc successfully with Yetus
0.12.0 + Java 11.
Ref: https://issues.apache.org/jira/browse/YETUS-972

Now I'm trying to fix the error in Yetus.

-Akira

On Sat, Oct 3, 2020 at 3:25 AM Ayush Saxena <ayushtkn@gmail.com> wrote:
>
> Hi Akira,
> Thanx for working on this.
> Is there anything blocking here? I think it isn’t working still.
> Can we point to a commit before Yetus-994 instead of master and get away with this? or
if there is no solution handy we may go ahead with approach #4 and then figure out how to
proceed.
>
> -Ayush
>
> > On 29-Sep-2020, at 5:31 PM, Masatake Iwasaki <iwasakims@oss.nttdata.co.jp>
wrote:
> >
> > Hi Akira,
> >
> > Thanks for working on this.
> > It looks like you are trying token on PR #2348.
> > https://github.com/apache/hadoop/pull/2348
> >
> > It it does not work, I think option #4 is reasonable.
> > I prefer using fixed/static version of toolchain in order to
> > avoid surprising the developers.
> > We can upgrade Yetus when JDK11 Javadoc issue is fixed.
> >
> > Regards,
> > Masatake Iwasaki
> >
> >> On 2020/09/29 2:55, Akira Ajisaka wrote:
> >> Apache Hadoop developers,
> >> After YETUS-994, the jenkins job updates the commit status instead of
> >> writing a comment to the pull request. It requires an OAuth token with
> >> write access to "repo:status" but now there is no such token for
> >> Apache Hadoop. I asked the infra team to create a token:
> >> https://issues.apache.org/jira/browse/INFRA-20906
> >> For now, I think there 4 options to get the information:
> >> 1. Attach a patch to the JIRA instead of GitHub
> >> 2. Update the Jenkinsfile for a while (Sample PR:
> >> https://github.com/apache/hadoop/pull/2346)
> >> 3. Search the job and get the comment from
> >> https://ci-hadoop.apache.org/job/hadoop-multibranch/
> >> 4. Create a JIRA to update the Jenkinsfile to use 0.12.0 instead of
> >> main. (JDK11 javadoc support is broken in Yetus 0.12.0)
> >> Sorry for the inconvenience.
> >> Regards,
> >> Akira
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
> >> For additional commands, e-mail: yarn-dev-help@hadoop.apache.org
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: yarn-dev-help@hadoop.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-dev-help@hadoop.apache.org


Mime
View raw message