hadoop-yarn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Wu (Jira)" <j...@apache.org>
Subject [jira] [Created] (YARN-10459) containerLaunchedOnNode method not need to hold schedulerApptemt lock
Date Wed, 14 Oct 2020 10:29:00 GMT
Ryan Wu created YARN-10459:
------------------------------

             Summary: containerLaunchedOnNode method not need to hold schedulerApptemt lock

                 Key: YARN-10459
                 URL: https://issues.apache.org/jira/browse/YARN-10459
             Project: Hadoop YARN
          Issue Type: Improvement
    Affects Versions: 3.1.3, 3.2.0
            Reporter: Ryan Wu
             Fix For: 3.2.1


 

Now, the containerLaunchedOnNode hold the SchedulerApplicationAttempt writelock, but looking
at the method, it does not change any field. And more seriously, this will affect the scheduler  

public void containerLaunchedOnNode(ContainerId containerId,
    NodeId nodeId) {
    // Inform the container
    writelock.lock
    try \{
    RMContainer rmContainer = getRMContainer(containerId);
    if (rmContainer == null) {
      // Some unknown container sneaked into the system. Kill it.
      rmContext.getDispatcher().getEventHandler().handle(
          new RMNodeCleanContainerEvent(nodeId, containerId));
      return;
    }

    rmContainer.handle(
        new RMContainerEvent(containerId, RMContainerEventType.LAUNCHED));

    }finally {      
     writeLock.unlock(); 
    }   
}

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-dev-help@hadoop.apache.org


Mime
View raw message