hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hong Wu <xunzhang...@gmail.com>
Subject Re: enforce -Werror (if gcc) in hawq?
Date Mon, 05 Sep 2016 16:30:43 GMT
-Werror is an option used to make sure that compiling warnings are
potentially bugs or errors. However, there is some trade-off between the
usage of C code(from standard's view) and the specific implementation of

In my opinion, C grammer is not that complex so we'd better to open this
option. You should try to open the flag and see what is going on. Just do


2016-09-05 18:05 GMT+08:00 Paul Guo <paulguo@gmail.com>:

> -Werror
> Make all warnings into errors.
> I've seen many cases (not just hawq) before that ignoring gcc warning leads
> to bugs. I'm wondering we should add the option for the gcc case. Given
> there may be a lot of warnings when building the common postgres code in
> hawq, we could at least enforce it in our own code at first
> (src/backend/cdb, src/backend/resourcemanager, src/test/feature, other
> directories?)? Any suggestion?

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message