From dev-return-6285-apmail-hawq-dev-archive=hawq.apache.org@hawq.incubator.apache.org Mon Feb 6 02:13:46 2017 Return-Path: X-Original-To: apmail-hawq-dev-archive@minotaur.apache.org Delivered-To: apmail-hawq-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1EAC719EDC for ; Mon, 6 Feb 2017 02:13:46 +0000 (UTC) Received: (qmail 20135 invoked by uid 500); 6 Feb 2017 02:13:46 -0000 Delivered-To: apmail-hawq-dev-archive@hawq.apache.org Received: (qmail 20058 invoked by uid 500); 6 Feb 2017 02:13:46 -0000 Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hawq.incubator.apache.org Delivered-To: mailing list dev@hawq.incubator.apache.org Received: (qmail 20047 invoked by uid 99); 6 Feb 2017 02:13:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Feb 2017 02:13:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 773271A00CF for ; Mon, 6 Feb 2017 02:13:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.999 X-Spam-Level: X-Spam-Status: No, score=-1.999 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id QsJsyn9mLcqU for ; Mon, 6 Feb 2017 02:13:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 28CDB5F24B for ; Mon, 6 Feb 2017 02:13:44 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 459DBE044B for ; Mon, 6 Feb 2017 02:13:43 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 761D92528B for ; Mon, 6 Feb 2017 02:13:42 +0000 (UTC) Date: Mon, 6 Feb 2017 02:13:42 +0000 (UTC) From: "Xiang Sheng (JIRA)" To: dev@hawq.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (HAWQ-1315) Function validateResourcePoolStatus() in resourcepool.c is logging the wrong information MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Xiang Sheng created HAWQ-1315: --------------------------------- Summary: Function validateResourcePoolStatus() in resourcepool.c is logging the wrong information Key: HAWQ-1315 URL: https://issues.apache.org/jira/browse/HAWQ-1315 Project: Apache HAWQ Issue Type: Bug Components: Resource Manager Reporter: Xiang Sheng Assignee: Ed Espino Fix For: 2.2.0.0-incubating The function "validateResourcePoolStatus()" in "resourcepool.c" is not logging the correct information in the message printed by "elog()" function in line 4123. In the snippet below: {code} if ( totalallocmem > mem || totalalloccore > core ) { elog(WARNING, "HAWQ RM Validation. Allocated too much resource in resource " "pool (%d MB, %lf CORE), maximum capacity (%d MB, %d CORE)", totalallocmem, totalalloccore, core, mem); } {code} The third and fourth parameters ('core' and 'mem') are swapped; the third string placeholder should be the maximum memory capacity, but it is printing the cores. The same happens with the fourth string placeholder. This leads to log messages of this kind in hawq master log: {code} 2017-02-02 01:30:03.014708 CET,,,p351048,th-384374496,,,,0,con4,,seg-10000,,,,,"WARNING","01000","HAWQ RM Validation. Allocated too much resource in resource pool (49152 MB, 6.000000 CORE), maximum capacity (5 MB, 40960 CORE)",,,,,,,0,,"resourcepool.c",4123, {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)