helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HELIX-707) Fix topstate handoff metrics.
Date Tue, 26 Jun 2018 23:38:00 GMT

    [ https://issues.apache.org/jira/browse/HELIX-707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524340#comment-16524340
] 

ASF GitHub Bot commented on HELIX-707:
--------------------------------------

GitHub user jiajunwang opened a pull request:

    https://github.com/apache/helix/pull/207

    [HELIX-707] Fix topstate handoff metrics.

    We've confirmed a bug in the logic that calculates topstate handoff duration.
    With this issue, if the previous master instance is offline, an older handoff start time
could be used to calculate the duration.
    This results in huge handoff duration in the Helix metrics.
    This change will fix this bug. If the previous node that holds topstate replica goes to
offline, the offline time will be used as the start time.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jiajunwang/helix master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/207.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #207
    
----
commit 7753b602cee6d08a8326a68f899cb089378aae9f
Author: Jiajun Wang <jjwang@...>
Date:   2018-04-27T17:56:43Z

    Fix topstate handoff metrics.
    
    We've confirmed a bug in the logic that calculates topstate handoff duration.
    With this issue, if the previous master instance is offline, an older handoff start time
could be used to calculate the duration.
    This results in huge handoff duration in the Helix metrics.
    This change will fix this bug. If the previous node that holds topstate replica goes to
offline, the offline time will be used as the start time.
    
    RB=1295351
    G=helix-reviewers
    A=lxia,hrzhang

----


> Fix topstate handoff metrics.
> -----------------------------
>
>                 Key: HELIX-707
>                 URL: https://issues.apache.org/jira/browse/HELIX-707
>             Project: Apache Helix
>          Issue Type: Bug
>    Affects Versions: 0.8.x
>            Reporter: Jiajun Wang
>            Assignee: Jiajun Wang
>            Priority: Major
>
> We've confirmed a bug in the logic that calculates topstate handoff duration.
> With this issue, if the previous master instance is offline, an older handoff start time
could be used to calculate the duration.
> This results in huge handoff duration in the Helix metrics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message