helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@apache.org
Subject [1/2] helix git commit: [HELIX-703] Change print statement to log statement
Date Tue, 26 Jun 2018 22:10:36 GMT
Repository: helix
Updated Branches:
  refs/heads/master ad5109848 -> 323fbd049


[HELIX-703] Change print statement to log statement


Project: http://git-wip-us.apache.org/repos/asf/helix/repo
Commit: http://git-wip-us.apache.org/repos/asf/helix/commit/0d77cbaf
Tree: http://git-wip-us.apache.org/repos/asf/helix/tree/0d77cbaf
Diff: http://git-wip-us.apache.org/repos/asf/helix/diff/0d77cbaf

Branch: refs/heads/master
Commit: 0d77cbafc6534dd7b0e9867b1dbf8a2266fd2281
Parents: ad51098
Author: Hunter Lee <narendly@gmail.com>
Authored: Mon Jun 25 14:31:00 2018 -0700
Committer: Hunter Lee <narendly@gmail.com>
Committed: Mon Jun 25 14:31:00 2018 -0700

----------------------------------------------------------------------
 helix-core/src/main/java/org/apache/helix/ConfigAccessor.java    | 2 +-
 helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/helix/blob/0d77cbaf/helix-core/src/main/java/org/apache/helix/ConfigAccessor.java
----------------------------------------------------------------------
diff --git a/helix-core/src/main/java/org/apache/helix/ConfigAccessor.java b/helix-core/src/main/java/org/apache/helix/ConfigAccessor.java
index 5562af5..70df719 100644
--- a/helix-core/src/main/java/org/apache/helix/ConfigAccessor.java
+++ b/helix-core/src/main/java/org/apache/helix/ConfigAccessor.java
@@ -290,7 +290,7 @@ public class ConfigAccessor {
    */
   public void set(HelixConfigScope scope, Map<String, String> keyValueMap) {
     if (scope == null || scope.getType() == null || !scope.isFullKey()) {
-      LOG.error("fail to set config. invalid config scope. scope: " + scope);
+      LOG.error("fail to set config. invalid config scope. scope: {}", scope);
       return;
     }
 

http://git-wip-us.apache.org/repos/asf/helix/blob/0d77cbaf/helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java
----------------------------------------------------------------------
diff --git a/helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java b/helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java
index 1151fc9..d3ee0c7 100644
--- a/helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java
+++ b/helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java
@@ -89,7 +89,7 @@ public final class ZKUtil {
   public static boolean isInstanceSetup(ZkClient zkclient, String clusterName, String instanceName,
       InstanceType type) {
     if (type == InstanceType.PARTICIPANT || type == InstanceType.CONTROLLER_PARTICIPANT)
{
-      ArrayList<String> requiredPaths = new ArrayList<String>();
+      ArrayList<String> requiredPaths = new ArrayList<>();
       requiredPaths.add(PropertyPathBuilder.instanceConfig(clusterName, instanceName));
       requiredPaths.add(PropertyPathBuilder.instanceMessage(clusterName, instanceName));
       requiredPaths.add(PropertyPathBuilder.instanceCurrentState(clusterName, instanceName));
@@ -100,7 +100,7 @@ public final class ZKUtil {
       for (String path : requiredPaths) {
         if (!zkclient.exists(path)) {
           isValid = false;
-          System.err.println("Invalid instance setup, missing znode path: " + path);
+          logger.error("Invalid instance setup, missing znode path: {}", path);
         }
       }
 


Mime
View raw message