From commits-return-7430-apmail-helix-commits-archive=helix.apache.org@helix.apache.org Tue Jun 26 22:10:37 2018 Return-Path: X-Original-To: apmail-helix-commits-archive@minotaur.apache.org Delivered-To: apmail-helix-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5551C180D5 for ; Tue, 26 Jun 2018 22:10:37 +0000 (UTC) Received: (qmail 18791 invoked by uid 500); 26 Jun 2018 22:10:37 -0000 Delivered-To: apmail-helix-commits-archive@helix.apache.org Received: (qmail 18755 invoked by uid 500); 26 Jun 2018 22:10:37 -0000 Mailing-List: contact commits-help@helix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@helix.apache.org Delivered-To: mailing list commits@helix.apache.org Received: (qmail 18746 invoked by uid 99); 26 Jun 2018 22:10:37 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jun 2018 22:10:37 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id F0632DFC7B; Tue, 26 Jun 2018 22:10:36 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: jxue@apache.org To: commits@helix.apache.org Date: Tue, 26 Jun 2018 22:10:36 -0000 Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: [1/2] helix git commit: [HELIX-703] Change print statement to log statement Repository: helix Updated Branches: refs/heads/master ad5109848 -> 323fbd049 [HELIX-703] Change print statement to log statement Project: http://git-wip-us.apache.org/repos/asf/helix/repo Commit: http://git-wip-us.apache.org/repos/asf/helix/commit/0d77cbaf Tree: http://git-wip-us.apache.org/repos/asf/helix/tree/0d77cbaf Diff: http://git-wip-us.apache.org/repos/asf/helix/diff/0d77cbaf Branch: refs/heads/master Commit: 0d77cbafc6534dd7b0e9867b1dbf8a2266fd2281 Parents: ad51098 Author: Hunter Lee Authored: Mon Jun 25 14:31:00 2018 -0700 Committer: Hunter Lee Committed: Mon Jun 25 14:31:00 2018 -0700 ---------------------------------------------------------------------- helix-core/src/main/java/org/apache/helix/ConfigAccessor.java | 2 +- helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/helix/blob/0d77cbaf/helix-core/src/main/java/org/apache/helix/ConfigAccessor.java ---------------------------------------------------------------------- diff --git a/helix-core/src/main/java/org/apache/helix/ConfigAccessor.java b/helix-core/src/main/java/org/apache/helix/ConfigAccessor.java index 5562af5..70df719 100644 --- a/helix-core/src/main/java/org/apache/helix/ConfigAccessor.java +++ b/helix-core/src/main/java/org/apache/helix/ConfigAccessor.java @@ -290,7 +290,7 @@ public class ConfigAccessor { */ public void set(HelixConfigScope scope, Map keyValueMap) { if (scope == null || scope.getType() == null || !scope.isFullKey()) { - LOG.error("fail to set config. invalid config scope. scope: " + scope); + LOG.error("fail to set config. invalid config scope. scope: {}", scope); return; } http://git-wip-us.apache.org/repos/asf/helix/blob/0d77cbaf/helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java ---------------------------------------------------------------------- diff --git a/helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java b/helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java index 1151fc9..d3ee0c7 100644 --- a/helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java +++ b/helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java @@ -89,7 +89,7 @@ public final class ZKUtil { public static boolean isInstanceSetup(ZkClient zkclient, String clusterName, String instanceName, InstanceType type) { if (type == InstanceType.PARTICIPANT || type == InstanceType.CONTROLLER_PARTICIPANT) { - ArrayList requiredPaths = new ArrayList(); + ArrayList requiredPaths = new ArrayList<>(); requiredPaths.add(PropertyPathBuilder.instanceConfig(clusterName, instanceName)); requiredPaths.add(PropertyPathBuilder.instanceMessage(clusterName, instanceName)); requiredPaths.add(PropertyPathBuilder.instanceCurrentState(clusterName, instanceName)); @@ -100,7 +100,7 @@ public final class ZKUtil { for (String path : requiredPaths) { if (!zkclient.exists(path)) { isValid = false; - System.err.println("Invalid instance setup, missing znode path: " + path); + logger.error("Invalid instance setup, missing znode path: {}", path); } }