helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hu...@apache.org
Subject [helix] 01/10: HELIX: Fix typo in ResourceControllerDataProvider's API
Date Thu, 28 Mar 2019 19:31:45 GMT
This is an automated email from the ASF dual-hosted git repository.

hulee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.git

commit cb92df719186e8ddc04ebdef00afb51ac3756331
Author: Hunter Lee <hulee@linkedin.com>
AuthorDate: Thu Mar 28 12:18:29 2019 -0700

    HELIX: Fix typo in ResourceControllerDataProvider's API
---
 .../controller/dataproviders/ResourceControllerDataProvider.java  | 4 ++--
 .../apache/helix/controller/stages/MessageGenerationPhase.java    | 8 +++++---
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/helix-core/src/main/java/org/apache/helix/controller/dataproviders/ResourceControllerDataProvider.java
b/helix-core/src/main/java/org/apache/helix/controller/dataproviders/ResourceControllerDataProvider.java
index 2ab4526..cf21230 100644
--- a/helix-core/src/main/java/org/apache/helix/controller/dataproviders/ResourceControllerDataProvider.java
+++ b/helix-core/src/main/java/org/apache/helix/controller/dataproviders/ResourceControllerDataProvider.java
@@ -239,10 +239,10 @@ public class ResourceControllerDataProvider extends BaseControllerDataProvider
{
   }
 
   /**
-   * Invalid the cached resourceAssignment (ideal mapping) for a resource
+   * Invalidate the cached resourceAssignment (ideal mapping) for a resource
    * @param resource
    */
-  public void invalidCachedIdealStateMapping(String resource) {
+  public void invalidateCachedIdealStateMapping(String resource) {
     _idealMappingCache.remove(resource);
   }
 
diff --git a/helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
b/helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
index 2894a49..b93a447 100644
--- a/helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
+++ b/helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
@@ -154,13 +154,15 @@ public abstract class MessageGenerationPhase extends AbstractBaseStage
{
         if (currentState == null) {
           currentState = stateModelDef.getInitialState();
           if (desiredState.equals(HelixDefinedState.DROPPED.name())) {
-            LogUtil.logDebug(logger, _eventId, String
-                .format("No current state for partition %s in resource %s, skip the drop
message",
+            LogUtil.logDebug(logger, _eventId,
+                String.format(
+                    "No current state for partition %s in resource %s, skip the drop message",
                     partition.getPartitionName(), resourceName));
 
             // TODO: separate logic of resource/task message generation
             if (cache instanceof ResourceControllerDataProvider) {
-              ((ResourceControllerDataProvider) cache).invalidCachedIdealStateMapping(resourceName);
+              ((ResourceControllerDataProvider) cache)
+                  .invalidateCachedIdealStateMapping(resourceName);
             }
             continue;
           }


Mime
View raw message