helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "bd2019us (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HELIX-816) new Date.getTime() can be changed to System.currentTimeMillis()
Date Fri, 12 Apr 2019 13:32:00 GMT
bd2019us created HELIX-816:

             Summary: new Date.getTime() can be changed to System.currentTimeMillis()
                 Key: HELIX-816
                 URL: https://issues.apache.org/jira/browse/HELIX-816
             Project: Apache Helix
          Issue Type: Bug
            Reporter: bd2019us

(1) helix-core/src/main/java/org/apache/helix/task/WorkflowDispatcher.java 334
(2) helix-core/src/main/java/org/apache/helix/messaging/handling/HelixStateTransitionHandler.java
(3) helix-core/src/main/java/org/apache/helix/messaging/AsyncCallback.java 111

I found that System.currentTimeMillis() can be used in these three locations instead of new
Since new Date() is a thin wrapper of light method System.currentTimeMillis(). The performance
will be greatly damaged if it is invoked too much times.
According to my local testing at the same environment, System.currentTimeMillis() can achieve
a speedup to 5 times (435 ms vs 2073 ms), when these two methods are invoked 5,000,000 times.

This message was sent by Atlassian JIRA

View raw message