helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hu...@apache.org
Subject [helix.wiki] branch master updated: Updated Pull Request Template (markdown)
Date Thu, 01 Aug 2019 19:33:26 GMT
This is an automated email from the ASF dual-hosted git repository.

hulee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.wiki.git


The following commit(s) were added to refs/heads/master by this push:
     new 88fb102  Updated Pull Request Template (markdown)
88fb102 is described below

commit 88fb1029258909c30958b1b175ca9db2b1dcf3ba
Author: Hunter Lee <narendly@gmail.com>
AuthorDate: Thu Aug 1 12:33:24 2019 -0700

    Updated Pull Request Template (markdown)
---
 Pull-Request-Template.md | 47 ++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 46 insertions(+), 1 deletion(-)

diff --git a/Pull-Request-Template.md b/Pull-Request-Template.md
index 296e907..44dddf8 100644
--- a/Pull-Request-Template.md
+++ b/Pull-Request-Template.md
@@ -38,4 +38,49 @@
 
 ### Code Quality
 
-- [ ] My diff has been formatted using helix-style.xml
\ No newline at end of file
+- [ ] My diff has been formatted using helix-style.xml
+
+Copy and paste the following markdown for your Pull Request:
+```
+### Issues
+
+- [ ] My PR addresses the following Helix issues and references them in the PR title:
+
+(#200 - Link your issue number here)
+
+### Description
+
+- [ ] Here are some details about my PR, including screenshots of any UI changes:
+
+(Write a concise description including what, why, how)
+
+### Tests
+
+- [ ] The following tests are written for this issue:
+
+(List the names of added unit/integration tests)
+
+- [ ] The following is the result of the "mvn test" command on the appropriate module:
+
+(Copy & paste the result of "mvn test")
+
+### Commits
+
+- [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines,
and I have squashed multiple commits if they address the same issue. In addition, my commits
follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
+  1. Subject is separated from body by a blank line
+  1. Subject is limited to 50 characters (not including Jira issue reference)
+  1. Subject does not end with a period
+  1. Subject uses the imperative mood ("add", not "adding")
+  1. Body wraps at 72 characters
+  1. Body explains "what" and "why", not "how"
+
+### Documentation
+
+- [ ] In case of new functionality, my PR adds documentation in the following wiki page:
+
+(Link the GitHub wiki you added)
+
+### Code Quality
+
+- [ ] My diff has been formatted using helix-style.xml
+```
\ No newline at end of file


Mime
View raw message